Skip to content

refactor(linter): remove unused allocator param in Runtime for LSP & tests #14489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

refactor(linter): remove unused allocator param in Runtime for LSP & tests #14489

merged 1 commit into from
Oct 13, 2025

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Oct 10, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 10, 2025
This was referenced Oct 10, 2025
Merged
Merged
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Oct 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Oct 10, 2025
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14489 will not alter performance

Comparing 10-10-refactor_linter_remove_unused_allocator_param_in_runtime_for_lsp_tests (b301795) with main (0082cda)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (b301795) during the generation of this report, so 0082cda was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Sysix Sysix marked this pull request as ready for review October 10, 2025 18:50
@Sysix Sysix requested a review from camc314 as a code owner October 10, 2025 18:50
@Sysix Sysix force-pushed the 10-10-refactor_linter_remove_lifetime_of_message_ branch from f5b2a15 to b924c78 Compare October 12, 2025 12:09
@Sysix Sysix force-pushed the 10-10-refactor_linter_remove_unused_allocator_param_in_runtime_for_lsp_tests branch from f5c2e7f to 2fabf08 Compare October 12, 2025 12:09
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Oct 13, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from 10-10-refactor_linter_remove_lifetime_of_message_ to graphite-base/14489 October 13, 2025 14:47
@graphite-app graphite-app bot changed the base branch from graphite-base/14489 to main October 13, 2025 14:53
@Sysix Sysix force-pushed the 10-10-refactor_linter_remove_unused_allocator_param_in_runtime_for_lsp_tests branch from 2fabf08 to 0b6328b Compare October 13, 2025 16:44
@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 16:44
Copilot
Copilot AI reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unused allocator parameter from the Runtime struct's methods in the linter service, affecting both the language server integration and test infrastructure.

  • Removes the unused allocator parameter from run_source and run_test_source methods
  • Updates all call sites to match the new method signatures
  • Simplifies the API by removing unnecessary parameters

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/service/runtime.rs Removes allocator parameter from run_source and run_test_source method signatures
crates/oxc_linter/src/service/mod.rs Updates LintService wrapper methods to match new Runtime method signatures
crates/oxc_linter/src/tester.rs Removes allocator variable declaration and updates method call to run_test_source
crates/oxc_language_server/src/linter/isolated_lint_handler.rs Removes allocator variable declaration and updates method call to run_source

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025
@graphite-app graphite-app bot force-pushed the 10-10-refactor_linter_remove_unused_allocator_param_in_runtime_for_lsp_tests branch from 0b6328b to b301795 Compare October 13, 2025 16:49
@graphite-app graphite-app bot merged commit b301795 into main Oct 13, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-10-refactor_linter_remove_unused_allocator_param_in_runtime_for_lsp_tests branch October 13, 2025 16:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sysix @camc314